Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shift sequence views such that centered markers are visible #713

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Jan 31, 2022

Addresses some of the concerns for #712

Here I shifted sequence (peptide) view's SVG viewBox 1/2 of nucleotide (aminoacid) width to the right. This allows for the markers close to the begging or end of the view to be visible.

This is required after adjustments made for centering markers in
#638 #644 #709

Addresses some of the concerns for #712

Here I shifted sequence (peptide) view's SVG viewBox 1/n of nucleotide (peptide) width to the right. This allows for the markers close to the begging or end of the view to be visible.

This is required after adjustments made for centering markers in 
#638 #644 #709
@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextstrain/nextclade/ASb4YwM4x7QtYbus94gJ7BXoKxfm
✅ Preview: https://nextclade-git-fix-markers-at-edges-nextstrain.vercel.app

Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ivan-aksamentov ivan-aksamentov merged commit dc94807 into master Feb 10, 2022
@ivan-aksamentov ivan-aksamentov deleted the fix/markers-at-edges branch February 10, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants